Skip to content

Conversation

Manishearth
Copy link
Member

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member Author

@bors r+ p=10 force

@bors
Copy link
Collaborator

bors commented Jun 19, 2016

📌 Commit 5bca023 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Jun 19, 2016

⌛ Testing commit 5bca023 with merge 3ba605f...

@bors
Copy link
Collaborator

bors commented Jun 19, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@Manishearth
Copy link
Member Author

@bors r+ p=10 force

@bors
Copy link
Collaborator

bors commented Jun 20, 2016

📌 Commit e3740b3 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Jun 20, 2016

⌛ Testing commit e3740b3 with merge 976dd25...

bors added a commit that referenced this pull request Jun 20, 2016
Rollup of 4 pull requests

- Successful merges: #34313, #34335, #34340, #34356
- Failed merges:
@alexcrichton
Copy link
Member

@bors: retry force clean

  • restarted buildbot

@bors
Copy link
Collaborator

bors commented Jun 20, 2016

⌛ Testing commit e3740b3 with merge fda55b1...

We no C++ and an incredibly small amount of C code as part of the build, so
there's not really much need for us to strictly check the version of compilers
as we're not really stressing anything. LLVM is a pretty huge chunk of C++ but
it should be the responsibility of LLVM to ensure that it can build with a
particular clang/gcc version, not ours (as this logic changes over time).

These version checks seem to basically just by us a regular stream of PRs every
six weeks or so when a new version is releases, so they're not really buying us
much. As a result, remove them and we can add then back piecemeal perhaps as a
blacklist if we really need to.
@alexcrichton
Copy link
Member

@bors: retry force clean

  • restarted buildbot

@bors
Copy link
Collaborator

bors commented Jun 20, 2016

⌛ Testing commit e3740b3 with merge 50d0470...

Stebalien and others added 2 commits June 20, 2016 14:23
- src links/redirects to extern fn from another crate had an extra '/'.
- src links to `pub use` of a crate module had an extra '/'.
- src links to renamed reexports from another crate used the new name
  for the link but should use the original name.
@bors
Copy link
Collaborator

bors commented Jun 20, 2016

💔 Test failed - auto-win-gnu-32-nopt-t

oli-obk and others added 7 commits June 21, 2016 10:08
This is mostly just a documentation fix as I don't think stability
attributes have any effect on macros.
Implement Binary, Octal, LowerHex and UpperHex for Wrapping<T>

Fixes: rust-lang#33659
Fix overflow error in thread::sleep

Fixes rust-lang#34330

I added a test to have a more clear error inside the function. Since `time_t` is `i64` and we expect `u64`, maybe we should changed the awaited type?
…r=brson

configure: Remove clang version checks

We no C++ and an incredibly small amount of C code as part of the build, so
there's not really much need for us to strictly check the version of compilers
as we're not really stressing anything. LLVM is a pretty huge chunk of C++ but
it should be the responsibility of LLVM to ensure that it can build with a
particular clang/gcc version, not ours (as this logic changes over time).

These version checks seem to basically just by us a regular stream of PRs every
six weeks or so when a new version is releases, so they're not really buying us
much. As a result, remove them and we can add then back piecemeal perhaps as a
blacklist if we really need to.
…ichton

rustdoc: Fix a couple of issues with src links to external crates

- src links/redirects to extern fn from another crate had an extra '/'.
- src links to `pub use` of a crate module had an extra '/'.
- src links to renamed reexports from another crate used the new name
  for the link but should use the original name.

Fixes: rust-lang#34274
…r=eddyb

don't warn on casting byte strs to slices

r? @durka
Mark concat_idents! unstable

This is mostly just a documentation fix as I don't think stability
attributes have any effect on macros.

[before](https://doc.rust-lang.org/nightly/std/macro.concat_idents!.html) [after](https://ollie27.github.io/rust_doc_test/std/macro.concat_idents!.html)
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants